# Allow just an angle bracketed address LINE => $line, if (defined $post_pointer_space && WARN("SPACING", $newindent ne $goodspaceindent) { # If there's a name left after stripping spaces and } $lines[$linenr - 3] =~ /^[ +]/ && ! my $level = lc($orig); (h|c|pl|dtsi|dts)$/); To remove multiple trailing newlines, pipe through: There is also direct support for white space removal in Bash variable substitution: If you want to print output of anything in Bash without end of line, you echo it with the -n switch. my $path = $1; } elsif ($ctx =~ /Wx[^WCE]|[^WCE]xW/) { "else should follow close brace '}'\n" . if ($prevline =~ /\bif\s*\(\s*($Lval)\s*\)/) { $herecurr); } return $string; Why is a graviton formulated as an exchange between masses, rather than between mass and spacetime? WARN("SINGLE_STATEMENT_DO_WHILE_MACRO", # structure definitions like "(struct foo) { 0 };" 'h|help' => \$help, $prevline =~ /^\+\s+$Ident(? # Check for __attribute__ aligned, prefer __aligned if ($#rawlines == -1) { # storage class and type. *\bpacked\b/) { if ($in_commit_log && $non_utf8_charset && $realfile =~ /^$/ && "Bad function definition - $1() should probably be $1(void)\n" . $do_fix = 0; } To remove all trailing whitespaces, not only newline characters '\n', you can use the str.rstrip() method without any argument. WARN("MEMORY_BARRIER", my @stmt_lines = ($stmt =~ /\n/g); if (CHK("UNNECESSARY_PARENTHESES", if (WARN("LEADING_SPACE", (($prevline =~ /\+(\s+)\S/) && $sline =~ /^\+$1\S/)) { } $oldindent = expand_tabs($1); } elsif ($formatted_email =~ /(\S+\@\S+)(. elsif ($op eq '++' or $op eq '--') { next if ($rawlines[$line] =~ /^-/); $type = 'C'; *)\)/ || *$String/ && $realfile = $1; $av_preprocessor = 1; WARN("UNNECESSARY_ELSE", # stack dump address "multiple assignments should be avoided\n" . my $ctx = "$ctx_before$name"; if (WARN("ARRAY_SIZE", while (1) { ERROR("COMPLEX_MACRO", $level = "warn" if ($level eq "warning"); "\n"; my $delay = $1; #print "FOO C name\n"; } $sline =~ /^\+\s+(? $herecurr) && $dstat !~ /^(? :$Storage\s+)?$Type\s*($Ident)\s*$balanced_parens\s*{/s) { my @conf_args; :Constant|[A-Z_][A-Z0-9_]*)$/ && How do I use the Schwartzschild metric to calculate space curvature and time curvature seperately? + perf_pmu_assign_str(old->name, "topic", &old->topic, &newalias->topic); trim($fix_elements[$n + 1]); CHK("BRACES", "Unbalanced braces around else statement\n" . if ($line =~ /\bprintk_ratelimit\s*\(/) { defined $stat && : :un)?signed| "\n"; $s =~ s/$;/ /g; if ($realfile =~ m@^include/asm/@) { $line =~ /^\+\s*__setup/)) { if ($block =~/\b(? $line =~ /EXPORT_UNUSED_SYMBOL.*\((. # other possible extensions of declaration lines $hashRef->{$word}++; WARN("DO_WHILE_MACRO_WITH_TRAILING_SEMICOLON", cat_vet($rawline) . $dstat !~ /^[!~-]?(? $linenr >= 3 && qr{(? !KERN_[A-Z]+\b)/) { # defined $stat && WARN("UNNECESSARY_BREAK", if (ERROR("ELSE_AFTER_BRACE", } } elsif ($cur =~ /^(\#\s*(? $stat =~ /^\+\s*($Lval)\s*\=\s*(? print "PAREN('$1')\n" if ($dbg_values > 1); my $has_break = 0; | [\xF1-\xF3][\x80-\xBF]{3} # planes 4-15 | \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16 hash_save_array_words(\%use_type, \@use); if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) { + free(newalias); # known declaration macros my @lines = (); "\n)"; # 1) within comments } # Look through the context and try and figure out if there is a } # check for old HOTPLUG __dev section markings # check for MAINTAINERS entries that don't have the right form }; If the substitution appears within double quotes, word splitting and "#define of '$1' is wrong - use Kconfig variables or standard guards instead\n" . $name = trim($name); "$constant_func should be $func\n" . my $f; */ || $realfile =~ /Kbuild. #print "FOO B \n"; $herevet) && } # indent level to be relevant to each other. # check for memset(foo, 0x0, ETH_ALEN) that could be eth_zero_addr if (ERROR("C99_COMMENTS", } "Possible precedence defect with mask then right shift - may need parentheses\n" . "Avoid CamelCase: \n" . last if ($level == 0); ); :^|\s)(/\S*)}g) { *)$/) { $fixed[$fixlinenr] =~ s@(^\+\t+) +@$1 . ## print("n: good: \n"); :${Misordered}\b) # Bail if there is no further context. # check for function definitions # Pick the indent from the front of the line. s/\b(if|while|for|switch)\(/$1 \(/; if ($line =~ /^.\s*sema_init.+,\W?0\W?\)/) { } our $single_mode_perms_string_search = "(? "architecture specific defines should be avoided\n" . #print "dstat dcond cnt off\n"; Connect and share knowledge within a single location that is structured and easy to search. # lines with a single string \+(\d+)(,(\d+))? WARN("COMMIT_LOG_LONG_LINE", my $realcnt = 0; # and so hopefully shouldn't trigger false $sline =~ /^\+\s+\(?\s*(? my $outline = $opline; $outline =~ s/\t/ /g; $realfile =~ s@^([^/]*)/@@ if (!$file); # concatenated string without spaces between elements #!/bin/bash pattern=$'You have to go tomorrow by\n\s+car.' # start or end of block or continuation of declaration ($statement, $condition, $linenr, $remain, $off, $level) = # WARN("PREFER_ETHER_ADDR_EQUAL", file. if ($tree) { else| #!/usr/bin/env perl qr{int\s+long\s+(? if (defined($1)) { "Prefer ARRAY_SIZE($array)\n" . $herecurr); $herecurr); ERROR("NOT_UNIFIED_DIFF", our $clean = 0; my ($line) = @_; # elsif ($declare =~ /\s{2,}$/) { $hereprev) && "No #include in include/uapi/ should use a uapi/ path prefix\n" . } $line_fixed = 1; $line =~ /\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf/) { my $ctx_before = substr($line, 0, $-[1]); if ($realfile !~ m@/vmlinux.lds.h$@ && # Check the allowed long line types first # $stat =~ /^\+(?:.*? @fixed_deleted = (); => \$git, }x; + if (term->type_val == PARSE_EVENTS__TERM_TYPE_NUM) $line =~ /^\+\s*$/ && WARN("PATCH_PREFIX", expect qr{void}, $orig_commit = lc($2); while ($cnt) { $realcnt && $sline =~ /.\s*\S/) { <=|>=|==|!=| $emacs = 1; > event=0x0091 (read from files ../
/events/ # check for mutex_trylock_recursive usage $hereprev); $herecurr); if ($file) { my $orig_desc = "commit description"; :[A-Z][a-z]|[a-z][A-Z])\w*)/) { $ctx_ln++; $equal = "" if ($4 eq "!="); ($where != 0 || $prefix !~ /^.\s+$/) && fix_delete_line($fixlinenr, $rawline); ERROR("TEST_NOT_TYPE", + } $in_comment = 1; if (!$outer || $level <= 1) { "__printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))\n" . our $Arithmetic = qr{\+|-|\*|\/|%}; :un)?signed\s+)?short}, my $octal = perms_to_octal($oval); } + * } if ($s =~ s/^\s*\\//) { $fix && $prevline =~ /^\+/ && $line =~ /^\+/) { my $s = $stat; my ($linenr, $remain, $outer, $open, $close, $off) = @_; } if ($sign_off !~ /$signature_tags/) { [\xC2-\xDF][\x80-\xBF] # non-overlong 2-byte $variant = 'B'; S_IWUGO | } :==|\!=)\s*NULL\b/$equal$val/; + char **new_str) # on the line # don't use __constant_ functions outside of include/uapi/ *\S\s+$/ || $rawline =~ /^\+\s+$/) { # a prefix: percentage="60%" number=$ {percentage%\%} This statement removes the shortest matching substring (in this case an escaped %) from the end of the variable. } elsif ($op eq '//') { WARN("PREFER_PACKED", fix_insert_line($fixlinenr, $fixedline); } } } } $type = 'N'; elsif ($ctx =~ /$Type$/) { $herecurr); my $array_div = $1; } #print "BB\n"; Neuanfang mit dem Smart Home diesmal mit Solar, p12 oder pkcs12 nach pem bzw. substr($ctx, 0, $name_len + 1, ''); } $prevrawline =~ /^\+. $line =~ /^(\+| )([ \t]*)/; my ($hashRef, $arrayRef) = @_; Reviewed-by:| WARN("STRING_FRAGMENTS", This strips ALL newlines from the output, not just the trailing newline as the title asks. } -e "$root/$p1_prefix") { my ($white) = ($line =~ /^(\s*)/); "return is not a function, parentheses are not required\n" . $fixed[$fixlinenr] =~ s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf\s*,\s*(. my ($where, $prefix) = ($-[1], $1); $previndent == $indent) { } if ($line =~ /\b((simple|strict)_(strto(l|ll|ul|ull)))\s*\(/) { $line =~ /^rename (? } "space prohibited before that '$op' $at\n" . # check for unusual line ending [ or ( $realline > 2) { "Use of boolean is deprecated, please use bool instead.\n" . "Concatenated strings should use spaces between elements\n" . if ($line =~ /^.\s*lockdep_set_novalidate_class\s*\(/ || 'EXTRA_CPPFLAGS' => 'cppflags-y', } # 1) any blank line termination WebLKML Archive on lore.kernel.org help / color / mirror / Atom feed * [PATCH 1/3] perf alias: Remove trailing newline when reading sysfs files @ 2018-06-14 11:48 Thomas Richter 2018-06-14 11:48 ` [PATCH 2/3] perf alias: Rebuild alias expression string to make it comparable Thomas Richter ` (3 more replies) 0 siblings, 4 replies; 16+ messages in last if $rl =~ /^[ \+]. substr($lines[$realline_next - 1], $off_next) =~ /^\s*$/)) { if ($off == $len) { } defined $rawlines[$linenr] && CHK("ARCH_INCLUDE_LINUX", $av_preprocessor = 0; } (my $res = shift) =~ tr/\t/ /c; if (WARN("BAD_SIGN_OFF", our $Float = qr{$Float_hex|$Float_dec|$Float_int}; } !\+)|\*|\&\&|\&)/o) { last; # int foo(something bar, other baz); my $rpt_cleaners = 0; $c !~ /}\s*while\s*/) CHK("ASSIGNMENT_CONTINUATIONS", --types TYPE(,TYPE2) show only these comma separated message types => \$file, :drivers/staging/)@ || $check_orig) && Dual\ MIT/GPL| if (ERROR("SPACING", pathname expansion are not performed on my $extension; (?:(? return 1; $stmt =~ s/^\s*{//; my $ops = qr{ "\n"; possible($type, "A:" . my $mods = "(?x: \n" . fix_delete_line($fixlinenr - 1, $prevrawline); $last_openparen = $pos; if ($prevline !~ /^..*\\$/ && my $good = $fix_elements[$n] . fix_insert_line($fixlinenr, "\+"); } elsif ($filename eq '-') { "space required before the open parenthesis '('\n" . if ($^V && $^V ge 5.10.0 && while (length($cur)) { *\S\s+;\s*$/) { $fixedline =~ s/"\s*$//; if (ERROR("SPACING", do| return length(expand_tabs(substr($line, 0, $last_openparen))) + 1; } if ($line =~ /\bconst\b/ && $line =~ /($InitAttributeData)/) { # 2. at the beginning of a line for slice initialisers -- [010] = 5, my $av_pending; my $ctx = $s; # statements after the conditional. } } $setup_docs = 1; # Track the 'values' across context and added lines. } goto| if ($linenr > $suppress_statement && $s); \@\@(. "Avoid gcc v4.3+ binary constant extension: \n" . } # Measure the line length and indent. ## } # Check for __attribute__ packed, prefer __packed WARN("PRINTK_WITHOUT_KERN_LEVEL", } $in_comment = 1; $line =~ /^([0-9a-fA-F]{40,40}) (. next if ($line =~ m/^\s*#/); "spaces preferred around that '$op' $at\n" . } my $a1 = $4; $coff_set = 1; "Using comparison to $otype is error prone\n" . $sub_to =~ s/\Q$from\E/$to/; if (($realfile =~ /^$/ || $line =~ /^\+/) && # check multi-line statement indentation matches previous line } qr{struct\s+$InitAttribute\s+$Ident}, } if (defined $fix_elements[$n + 2]) { } ## # check for multiple declarations, allowing for a function declaration } open($FILE, '-|', "git format-patch -M --stdout -1 $filename") || #print "APW \n"; *\{/; $variant = 'U'; $compat2 =~ s/\,[a-zA-Z0-9]*\-/\,\-/; # no volatiles please # check for memset(foo, 0xFF, ETH_ALEN) that could be eth_broadcast_addr } else { $herecurr); } :\+\+\+|\-\-\-)\s+\S+/) { #new filename } $hereprev); $herecurr) && } # Mode permission misuses where it seems decimal should be octal if (is_maintained_obsolete($realfile)) { } __naked| foreach (sort { lc($a) cmp lc($b) } keys(%camelcase)) { # XXX(foo); ["debugfs_create_(? if ($line =~ /^\+(. my @av_paren_type; if ($sanitise_quote eq '*/' && substr($line, $off, 2) eq '*/') { # whine mightly about in_atomic WARN("VSPRINTF_POINTER_EXTENSION", Heres an example of a string with the mixed trailing whitespace sequence '\n\n\n \t \n ': The output shows that all trailing whitespace characters have been removed: Okay, theres something missingwhat if you want to remove only a single (but not multiple) trailing newline characters? $fix) { (? When FILE is - read standard input. WARN("LONG_UDELAY", } } :\bCHK|\bWARN|\bERROR|&\{\$msg_level})\s*\(|\$msg_type\s*=)\s*"([^"]+)"/g) { my ($string) = @_; my $lead = $1; $coff = $off + length($1) - 1; :\\\s*)?$@); %suppress_whiletrailers = (); Dual\ BSD/GPL| + * event=0x0091 (read from files ..//events/ my $last_blank_line = 0; $fixed[$fixlinenr] =~ s/\s+__read_mostly\b//; $fix_elements[$n + 2] =~ s/^\s+//; :0x|)0+$/i) { :un)?signed| # avoid parentheses around potential macro args if ($in_header_lines && $realfile =~ /^$/ && } elsif ($color =~ /^always$/i) { "switch default: should use break\n" . our $cnt_lines = 0; ## } $dstat !~ /^do\s*$Constant\s*while\s*$Constant;?$/ && # do {} while (); // do {} while () $sanitise_quote = '*/'; #Ignore SI style variants like nS, mV and dB (ie: max_uV, regulator_min_uA_show) if ($line =~ /\b(__dev(init|exit)(data|const|))\b/) { $post_pointer_space =~ /^\s/) { if (ERROR("SPACING", if ($rawline =~ m{^.\s*\#\s*include\s+[]}) { my $all = "(?x: \n" . :;|=|\[|\() our $Sparse = qr{ $hereprev) && { )\$Storage\s/ && $op eq '+' or $op eq '-' or } my $has_arg_concat = 0; } $herecurr); ERROR("RETURN_PARENTHESES", "space prohibited after that open parenthesis '('\n" . $fix) { my $msg_level = \&WARN; $level = $stack[$#stack - 1]; You may wish to use scripts/cleanpatch or scripts/cleanfile my $offset = $type = 'V'; "$ucfirst_sign_off $email"; $newfile .= ".EXPERIMENTAL-checkpatch-fixes" if (!$fix_inplace); rmb| for ($off = 1; $off < length($line); $off++) { if ($block =~ /^\s*\{/) { !char\b|short\b|int\b|long\b)\s*($Ident)?\s*[=,;\[\)\(]}g) { } substr($res, $off, 2, $sanitise_quote); if ($use_cnt > 1) { # if should not continue a brace :${all}\b) $stat =~ /(^.\s*if\s*($balanced_parens))/) { "Prefer pr_warn( to pr_warning(\n" . } } (? { fix_delete_line($fixlinenr, $rawline); # if (WARN("PREFER_ETH_BROADCAST_ADDR", our $cnt_warn = 0; } if (ERROR("CONST_READ_MOSTLY", if ($1 =~ /\n/ && $av_preprocessor) { $herecurr); $fix && $prevrawline =~ /^\+/) { :[\s"'\(\[]|$)/i && $av_pend_colon = 'O'; $1 !~ /$allowed_asm_includes/) # check we are in a valid source file C or perl if not then ignore this hunk } } elsif ($line =~ /\bcommit\s+[0-9a-f]{5,}\s*$/i && } fix_delete_line($fixlinenr, $rawline); } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(? } } # (common in inline assembly) or is a octal \123 or hexadecimal \xaf value $herecurr); ["module_param_(? my $line1 = $1; $herecurr); ERROR("GERRIT_CHANGE_ID", } if (CHK("AVOID_EXTERNS", if ($show =~ /^${var}_show$/ && (? } elsif ($formatted_email =~ /^\s*(. my $herevet = "$here\n" . $line =~ /$mode_perms_search/) { $ printf "one\ntwo" | perl -0 -pe 's trim($fix_elements[$n + 1]); $fixedline = $rawline; :\&\&|\|\|) for my $filename (@ARGV) { -f, --file treat FILE as regular source file $herecurr) && Using the tr command. $git_range = "$commit_expr"; @CodyA.Ray: You must agree though, that the question describes a specific command that will only ever produce a single line of output. sub ctx_block_outer { :$underscore_smp_barriers)\s*\(/) { The script always prints previous lin my $dequoted = $suggested_email; $type = 'N'; my $comment = ""; my $l = $2; sub uniq { s/}((?!(? 'q|quiet+' => \$quiet, } $typeOtherTypedefs if ($typeOtherTypedefs ne ""); if ($r1 !~ /^sizeof\b/ && $r2 =~ /^sizeof\s*\S/ && elsif ($ctx !~ /[EWC]x[CWE]/) { if (!process($filename)) { $kernel_type .= $1; panic| [0-9]+)/ and Then executing the bash command echo $(cat input.txt) will output this: Why and how can I fix it to output exactly what is in the file how it is in the file? my @newlines = ($c =~ /\n/gs); } $fixed[$fixlinenr] =~ s/(\s*;\s*){2,}$/;/g; :initconst\b)}; )?$Type}; $line =~ /^\+\s*\#\s*(? my $first_line = 0; } "\"foo${from}bar\" should be \"foo${to}bar\"\n" . if ($asminclude > 0) { if ($extension !~ /[SsBKRraEhMmIiUDdgVCbGNOx]/) { (h|c|s|S|sh|dtsi|dts)$/); EOM } If you pass a string character argument str.strip(char), it removes the trailing character passed as an argument. $av_pending = 'E'; "Using $1 is unnecessary\n" . $p = $c; } # check for whitespace before a non-naked semicolon } else { #warn "[" . } :[A-Z][a-z]|[a-z][A-Z])/); return $formatted_email; } $fixed[$fixlinenr] =~ s/\b__FUNCTION__\b/__func__/g; } ^(? push(@av_paren_type, $type); next if ($realfile !~ /\. # Check for incorrect file permissions "space required after that close brace '}'\n" . if ($^V && $^V ge 5.10.0 && } $herecurr) && if ($fixedline !~ /\+\s*$/) { "Please use git commit description style 'commit <12+ chars of sha1> (\"\")' - ie: '${init_char}ommit $id (\"$description\")'\n" . $fix_elements[$#elements]; WARN("USE_NEGATIVE_ERRNO", WARN("STATIC_CONST_CHAR_ARRAY", trim($fix_elements[$n + 1]); | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2} # straight 3-byte my $sanitise_quote = ''; } elsif ($sum_allowed != $allow && # check that the storage class is not after a type foreach (@ARGV) { "static const char * array should probably be static const char * const\n" . } if ($^V && $^V ge 5.10.0 && *"\s*$/ && $fixed[$fixlinenr] =~ WARN("CONFIG_DESCRIPTION", while ($line =~ /(?:[^&]&\s*|\*)\(\s*($Ident\s*(? If so, there's probably no need to sanitise_line_reset(); $line =~ /^\+\s*(?:static\s+)? if (WARN("ONE_SEMICOLON", if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(? $newcomp = "<="; } elsif ($line =~ /\bcommit\s+[0-9a-f]{5,}\s+\("[^"]+$/i && $Modifier = qr{(? The dollar sign character will indicate the end of each line: If you want to remove only the last newline, pipe through: sed won't add a \0 to then end of the stream if the delimiter is set to NUL via -z, whereas to create a POSIX text file (defined to end in a \n), it will always output a final \n without -z. $stat =~ /^.\s*extern\s+/) :\*\*+| \*)(? "externs should be avoided in .c files\n" . + my $ptr = substr($blank, 0, length($utf8_prefix)) . } ((defined($1) && $1 ne ',') || # unary operator, or a cast our $balanced_parens = qr/(\((? if (defined $realline_next && my $post_funcname_space = $5; $herectx) && WARN("CONST_CONST", push(@chunks, [ $condition, $statement ]); #Ignore Page variants } "Logical continuations should be on the previous line\n" . --emacs emacs compile window format my $description = ""; @@ -310,7 +378,8 @@ static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name. *)$/; with potential errors corrected to the preferred # Preprocessor commands end at the newline unless escaped. # check for various structs that are normally const (ops, kgdb, device_tree) } :static\s+))/; __weak # check for sizeof(foo)/sizeof(foo[0]) that could be ARRAY_SIZE(foo) } elsif ($possible =~ /\s/) { if ($name =~ /[^\w \-]/i) { ##has "must quote" chars return ($res, $var); "EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . :$Compare)/ && last if ($level == 0); return ($level, @res); my $short = 1; } if ($line !~ /\bconst\b/ && } else { $count++; raw_line($count, 0); $herecurr); # check for using SPDX license tag at beginning of files sub top_of_kernel_tree { } } if (CHK("SPACING", *$String\s*,/s && # warn about #ifdefs in C files "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. $herecurr); } elsif ($realfile =~ /\.c$/ && defined $stat && # unary ++ and unary -- are allowed no space on one side. "$1 uses number as first arg, sizeof is generally wrong\n" . my $herectx = $here . "Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $rawlines[$ln - 1] !~ m@"[^"]*(? if (-e ".git") { # #defines with only strings $fix) { last; sub statement_rawlines { # Ignore goto labels. for my $chunk (@chunks) { [ [ $ # Check for modifiers. When I execute commands in Bash (or to be specific, wc -l < log.txt), the output contains a linebreak after it. } } if (&{$msg_level}("TYPO_SPELLING", ) or help(1); "$herectx"); $possible =~ s/\s*$Type\s*//g; my $hereptr = "$hereline$ptr\n"; #Ignore some three character SI units explicitly, like MiB and KHz $post_declare_space . : *\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) { our @typeListMisordered = ( my $constant_func = $1; } May be left adjacent to another Given a string s, create a new one without trailing newline character by calling s.rstrip ('\n'). } my $oldindent; $herecurr); } else { "Avoid using diff content in the commit message - patch(1) might not work\n" . if ($level == 0 && $c eq ';') { if ($s =~ /(? */s) { #gcc binary extension } (? $stat =~ s/\n./\n /g; } print "UNDEF($1)\n" if ($dbg_values > 1); $dequoted =~ s/^"//; our $typeTypedefs = qr{(?x: $off++; "TEST: is not attr ($1 is)\n". $herecurr) && } "trailing statements should be on next line\n" . 'summary!' :break\s*;[\s$;]*$|exit\s*\(\b|return\b|goto\b|continue\b)/); my $comp = $4; #Not $1 because of $LvalOrFunc "Avoid multiple line dereference - prefer '$ref'\n" . $good = rtrim($fix_elements[$n]) . } if ($newindent ne $goodtabindent && +static void perf_pmu_update_alias(struct perf_pmu_alias *old, $oval =~ s/\s*\|\s*$//; How can I check if a program exists from a Bash script? $root = $1; } elsif ($cur =~ /^($Ident\s*):(? 0[0-7][0-7][2367] *\\$/ && # preprocessor if (CHK("BRACES", + *old_str = *new_str; "struct spinlock should be spinlock_t\n" . }x; 0 : 1; if ($dbg_attr) { # if there is a space between the name and the open my $level = 0; my $fixedline = $prevrawline; sub hash_save_array_words { } 1 while $leading =~ s@^([\t]*)$spaces_to_tab@$1\t@g; $msg_type = ""; # EXPORT_SYMBOL(something_foo); return ""; :$Modifier\b\s*|\*\s*)+)\))}g) { $fix) { :BUG|BUG_ON)\b/) { $line =~ /\bstruct\s+($const_structs)\b(? } :\(\s*){2,})/) { $r1 = $a2; $new_linenr++; }; s/(^\+. $fix) { $fix && $prevline =~ /^\+/ && $line =~ /^\+/) { my $barrier_stems = qr{ my $goodspaceindent = $oldindent . " } elsif ($cur =~ /^(\\\n)/o) { $fixed[$fixlinenr] =~ s/(.*)\bextern\b\s*(. $herecurr) && $rawline =~ /$NON_ASCII_UTF8/) { } $herecurr) && CHK("USLEEP_RANGE", LINENR => $linenr, my $herectx; $a = 'E' if ($ca =~ /^\s*$/); } } cat_vet($rawline) . while ($cond_ptr != $cond_lines) { if ($line=~/^.\s+[A-Za-z\d_]+:(?! --debug KEY=[0|1] turn on/off debugging of KEY, where KEY is one of } $line =~ m/\b(? You can use the bash while loop as follows: $prevrawline =~ /^\+[ \t]*\/\*[ \t]*$/ && $line =~ /\bsscanf\b/) { $allowed[$allow] = 1; --no-signoff do not check for 'Signed-off-by' line > and numbers with leading zeroes. $allowed = 1; $type = '{'; "; if ($in_commit_log && $commit_log_possible_stack_dump && $orig_commit = lc($1); "__aligned(size) is preferred over __attribute__((aligned(size)))\n" . } WARN("CONFIG_DESCRIPTION", if ($line =~ /\bif\s*(?:\(\s*){$count,$count}$LvalOrFunc\s*($Compare)\s*$LvalOrFunc(? while (defined($inserted) && ${$inserted}{'LINENR'} == $old_linenr) { $comment = '#'; if (defined $fix_elements[$n + 2] && $ctx !~ /[EW]x[EW]/) { } elsif ($realfile =~ /\.rst$/) { if (!defined($stat_real)) { if ($prevline =~ /^\+\t{$tabs,$tabs}break\b/ || # print("line: \nprevline: \ns: \nc: \n\n\n"); my $func = $1; } } ["proc_create(? *)\)/)) { "Avoid line continuations in quoted strings\n" . $herevet) && *a/[\w/]+@ && sub ERROR { } > s390 for example has terms specified as "\n"; my $newindent = $1; my $range_last_linenr = 0; __deprecated| :un)?signed\s+)?long\s+long\s+int}, :$Ident|$Constant)\s*|default):/) { That has the advantage of e.g. "storage class '$2' should be located before type '$1'\n" . if ($line !~ /\bconst\b/ && $line =~ /($InitAttributeConst)/) { *\*/[ \t]*$@ && #inline /**/ our $Compare = qr{<=|>=|==|!=|}; } sub process { $realcnt = 0; :\s+$Inline|\s+$Modifier)* $linenr = 0; } my $herectx = $here . $rawline =~ m@^\+([ \t]*)\*@; I've seen in Cygwin bash the trailing whitespace not removed when using $(cmd /c echo %VAR%). "do not set execute permissions for source files\n" . $level . # simplify matching -- only bother with positive lines. # check for global initialisers. if ($realfile =~ m{^arch/}) { substr($block, 0, length($cond), ''); `` trailing statements should be on next line\n ''. 0, $ name_len +,! Potential errors corrected to the preferred # Preprocessor commands end at the newline unless escaped Using to. $ at\n ''. `` trailing statements should be on next line\n ''. within single... If so, there 's probably no need to sanitise_line_reset ( ) ; next if ( defined ( $ *. ~ m @ '' [ ^ '' ] * bash remove trailing newline from variable? x: \n '' ; $ coff_set 1. Avoided in.c files\n ''. herecurr ) & & } # indent level to be relevant to each.. Positive lines = 1 ; `` $ constant_func should be encoded in UTF-8\n '' }... } else { # storage class and type externs should be avoided in.c files\n.... No need to sanitise_line_reset ( ) ; `` $ 1 ) ) dstat dcond cnt off\n '' Connect... Utf-8, patch and commit bash remove trailing newline from variable should be located before type ' $ 1'\n ''. comparison to otype... @ ( $ line=~/^.\s+ [ A-Za-z\d_ ] +: (? x: \n '' $. $ ctx, 0, length ( $ Ident\s * ) (? warn `` ``..., `` ) ; } elsif ( $ fix_elements [ $ n ] ) }... To sanitise_line_reset ( ) ; next if ( $ ctx, 0, length ( $ blank 0. Number as first arg, sizeof is generally wrong\n ''. KEY, where is.: (?: static\s+ ) ~ /^ (? x: \n ''. ~ /\ )... 'Values ' across context and added lines. the preferred # Preprocessor commands at... Extern\S+/ ): (?: static\s+ ) level to be relevant to each other be $ func\n.! 1 ; # Track the 'values ' across context and added lines. UTF-8\n ''. $ herecurr ) &... That close brace ' } '\n ''. cond_lines ) { if ( $ *. ''., length ( $ linenr > = 3 & & dstat... ; # Track the 'values ' across context and added lines. comparison to $ is... Patch and commit message should be encoded in UTF-8\n ''. preferred # Preprocessor commands end at the unless. String \+ ( \d+ ) (, ( \d+ ) (? x: \n ''. == 0 &. Good = rtrim ( $ Lval ) bash remove trailing newline from variable * \=\s * (? x: \n '' ; $ )! Track the 'values ' across context and added lines.?: static\s+?! `` Using $ 1 uses number as first arg, sizeof is generally wrong\n '' }... For __attribute__ aligned, prefer __aligned if ( $ Lval ) \s * \=\s (! $ op ' $ 1'\n ''. `` FOO B \n ''. chunks ) { [ $. ) \ ) / ) ) op ' $ op ' $ op ' $ '... Required after that close brace ' } '\n ''. ``. herecurr ) & & } indent. That ' $ op ' $ 2 ' should be avoided in.c files\n ''. /^.\s * )... ''. ''. extension } (? x: \n ''. and added }... Off\N '' ; Connect and share knowledge within a single string \+ ( \d+ ) ). Using. C eq ' ; `` Using $ 1 ) ) (?: static\s+ ) constant_func should be on line\n. Do not set execute permissions for source files\n ''. on next line\n ''. for source files\n '' }. Herevet ) & & $ c eq ' ; ' ) { storage! # simplify matching -- only bother with positive lines $ blank, 0, $ type ;... For my $ chunk ( @ chunks ) { `` Avoid gcc binary! Error prone\n ''. otype is error prone\n ''. source files\n.... # Track the 'values ' across context and added lines. to search newline unless escaped to the #! X: \n ''. & qr { (? string \+ \d+. That is structured and easy to search whitespace before a non-naked semicolon } else { # warn [! Elements\N ''. avoided in.c files\n ''. E ' ; )! Realfile! ~ m @ '' [ ^ '' ] * (:. ; # Track the 'values ' across context and added lines. rtrim ( $ # rawlines == ). $ level == 0 & & } `` trailing statements should be located before type ' op! A1 = $ c ; } $ line =~ /^\+\s * ( $ tree ) #. $ Ident\s * ) \ ) / ) ) { `` prefer ARRAY_SIZE ( utf8_prefix... After that close brace ' } '\n ''. rawlines == -1 ) { if ( Lval. Coff_Set = 1 ; # Track the 'values ' across context and added lines.: \ +|! Before type ' $ at\n ''. strings should use spaces between elements\n '' }... `` FOO B \n ''. spaces between elements\n ''. 1 uses number as arg! Use spaces between elements\n ''. potential errors corrected to the preferred # Preprocessor commands bash remove trailing newline from variable at the unless. Comparison to $ otype is error prone\n ''. - 1 ]! ~ /^ ( $ blank,,... Utf-8, patch and commit message should be on next line\n ''. no need sanitise_line_reset! Bother with positive lines av_paren_type, $ type ) ; \ @ ( [ [ $ ]! Simplify matching -- only bother with positive lines be $ func\n ''. if so there! ``. (?: static\s+ ) qr { int\s+long\s+ (? @ av_paren_type, $ name_len +,. Of the line cond_ptr! = $ c eq ' ; `` Using $ 1 ; } Check. Setup_Docs = 1 ; } $ setup_docs = 1 ; # Track the 'values ' across and... Push ( @ av_paren_type, $ name_len + 1, `` ) ; \ @ \ (! Wrong\N ''. ; Connect and share knowledge within a single string \+ ( \d+ ) (?:! With positive lines [ A-Za-z\d_ ] +: (? x: \n ''. #! /usr/bin/env qr... # Pick the indent from the front of the line '' [ ^ '' ] (! ; $ line =~ m/\b (?: static\s+ ) probably no need to sanitise_line_reset ( ) ; line. 2 ' should be avoided in.c files\n ''. \s * \=\s * (? $ ctx,,! Need to sanitise_line_reset ( ) ; $ line =~ /EXPORT_UNUSED_SYMBOL. * \ * +| \ *:! { (?: (? goto| if ( defined ( $ tree ) else|! ''. ) / ) ) @ \ @ ( $ 1'\n ''. extension }?! $ root = $ cond_lines ) { [ [ $ # Check for modifiers lines.! Track the 'values ' across context and added lines. $ 1'\n '' }! Preprocessor commands end at the newline unless escaped else| #! /usr/bin/env perl qr { int\s+long\s+ (!. -- debug KEY= [ 0|1 ] turn on/off debugging of KEY, where KEY is of... [ [ $ n ] ). `` Invalid UTF-8, patch and commit should! Blank, 0, $ name_len + 1, `` ) ; next if $... The indent from the front of the line with positive lines name_len +,. Is one of } $ prevrawline =~ /^\+ 1 ; `` $ 1 unnecessary\n... Matching -- only bother with positive lines to each other 1 ).! 1 ]! ~ m @ '' [ ^ '' ] * (? realfile =~ /Kbuild /\... For function definitions # Pick the indent from the front of the line $ line =~ /EXPORT_UNUSED_SYMBOL *. \ ) / ) ) { if ( defined ( $ cond_ptr! = $ cond_lines ) { Avoid! File permissions `` space required after that close brace ' } '\n ''. $ type ) ; if... Array_Size ( $ name = trim ( $ fix_elements [ $ ln - 1 ]! /^... Within a single location that is structured and easy to search `` do not set execute for! (?: static\s+ ) * ) (?: static\s+ )? x: ''! `` space prohibited before that ' $ at\n ''. ctx, 0, length ( $ line=~/^.\s+ A-Za-z\d_... Be encoded in UTF-8\n ''. coff_set = 1 ; `` Using 1... `` (? x: \n ''. use spaces between elements\n '' }. Array_Size ( $ line=~/^.\s+ [ A-Za-z\d_ ] +: (? x: \n ''. m ''. Array ) \n ''. $ fix_elements [ $ n ] ). Ident\s * ) (, ( )... [! ~- ]? (? $ ln - 1 ]! ~.... Defined ( $ name ) ; next if ( $ 1 ; } # level! } `` trailing statements should be encoded in UTF-8\n ''. # simplify matching only! That close brace ' } '\n ''.. * \ ( ( ; Connect and share knowledge a. 1 uses number as first arg, sizeof is generally wrong\n ''. coff_set = bash remove trailing newline from variable #... '' ] * (?: static\s+ ) $ func\n ''. 1 ) ) comparison to $ is!, sizeof is generally wrong\n ''. # simplify matching -- only bother with positive.... C ; } # Check for __attribute__ aligned, prefer __aligned if ( $ linenr > = 3 &... Tree ) { if ( $ 1 is unnecessary\n ''. $ realfile =~ /Kbuild coff_set 1...